Fix SFTP data truncation by moving sentSzSave to state structure #785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move sentSzSave variable to state structure in wolfSSH_SFTP_SendWritePacket
This PR makes the following changes:
sentSzSavevariable from being a local variable in thewolfSSH_SFTP_SendWritePacketfunction to being a member of theWS_SFTP_SEND_WRITE_STATEstructure.Changes Made
sentSzSaveas a member variable to theWS_SFTP_SEND_WRITE_STATEstructurewolfSSH_SFTP_SendWritePacketfunctionstate->sentSzSaveinstead of the local variableTesting
The changes have been tested locally using the following procedure:
-Nflag (non-blocking sockets) to connect to the serverputcommand to transfer a 2MB test fileThe test confirmed that the changes did not affect the functionality of the SFTP file transfer and that the non-blocking mode works correctly.
Link to Devin run: https://app.devin.ai/sessions/ce8d743061084bff9e1dc755bd55c96e
Requested by: [email protected]